Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sample for transaction timeouts #2599

Merged
merged 4 commits into from Aug 23, 2023

Conversation

olavloite
Copy link
Collaborator

Our current samples show how to set timeout and retry settings for all RPC invocations for a given RPC method, and how to set a timeout for a single statement, but we did not have a sample for setting a timeout for an entire transaction. This is something that customers have been asking multiple times. This sample shows how a transaction timeout can be set by using a gRPC context with a timeout.

Our current samples show how to set timeout and retry settings for all
RPC invocations for a given RPC method, and how to set a timeout for a
single statement, but we did not have a sample for setting a timeout for
an entire transaction. This is something that customers have been asking
multiple times. This sample shows how a transaction timeout can be set
by using a gRPC context with a timeout.
@olavloite olavloite requested review from a team as code owners August 21, 2023 06:55
@snippet-bot
Copy link

snippet-bot bot commented Aug 21, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. labels Aug 21, 2023
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor nit

@olavloite olavloite added the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 59cec9b into main Aug 23, 2023
22 of 24 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the transaction-timeout-sample branch August 23, 2023 07:36
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants