Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retry aborted errors for writeAtLeastOnce #2627

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

olavloite
Copy link
Collaborator

The writeAtLeastOnce method could fail with an Aborted error if Cloud Spanner would abort the transaction during the single Commit RPC invocation that this method executes. This can for example happen if a schema change is executed while this method is being called.

Fixes #2626

The `writeAtLeastOnce` method could fail with an Aborted error if Cloud
Spanner would abort the transaction during the single Commit RPC
invocation that this method executes. This can for example happen if a
schema change is executed while this method is being called.

Fixes #2626
@olavloite olavloite requested a review from a team as a code owner September 15, 2023 13:30
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Sep 15, 2023
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner September 15, 2023 13:32
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 18, 2023
@olavloite olavloite merged commit 2addb19 into main Sep 25, 2023
24 checks passed
@olavloite olavloite deleted the retry-write-at-least-once branch September 25, 2023 13:12
surbhigarg92 pushed a commit to surbhigarg92/java-spanner that referenced this pull request Oct 5, 2023
* fix: retry aborted errors for writeAtLeastOnce

The `writeAtLeastOnce` method could fail with an Aborted error if Cloud
Spanner would abort the transaction during the single Commit RPC
invocation that this method executes. This can for example happen if a
schema change is executed while this method is being called.

Fixes googleapis#2626

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatabaseClient#writeAtLeastOnce does not retry Aborted errors
3 participants