fix: NullPointerException on AbstractReadContext.span #3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a storm of requests for sessions leads to the session pool being temporarily exhausted, the session pool will return RESOURCE_EXHAUSTED errors for those requests. That error was however not propagated to any additional threads that were also waiting for the same transaction, and would cause these threads to continue with the transaction even though no valid session had been assigned. This fix ensures that the exception is also propagated to any thread waiting for the session.
product-auto-label
bot
added
size: m
rahul2393
approved these changes
Apr 16, 2024
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
🤖 I have created a release *beep* *boop* --- ## [6.65.0](https://togithub.com/googleapis/java-spanner/compare/v6.64.0...v6.65.0) (2024-04-20) ### Features * Remove grpclb ([#2760](https://togithub.com/googleapis/java-spanner/issues/2760)) ([1df09d9](https://togithub.com/googleapis/java-spanner/commit/1df09d9b9189c5527de91189a063ecc15779ac77)) * Support client-side hints for tags and priority ([#3005](https://togithub.com/googleapis/java-spanner/issues/3005)) ([48828df](https://togithub.com/googleapis/java-spanner/commit/48828df3489465bb53a18be50808fbd435f3e896)), closes [#2978](https://togithub.com/googleapis/java-spanner/issues/2978) ### Bug Fixes * **deps:** Update the Java code generator (gapic-generator-java) to 2.39.0 ([#3001](https://togithub.com/googleapis/java-spanner/issues/3001)) ([6cec1bf](https://togithub.com/googleapis/java-spanner/commit/6cec1bf1bb44a52c62c2310447c6a068a88209ea)) * NullPointerException on AbstractReadContext.span ([#3036](https://togithub.com/googleapis/java-spanner/issues/3036)) ([55732fd](https://togithub.com/googleapis/java-spanner/commit/55732fd107ac1d3b8c16eee198c904d54d98b2b4)) ### Dependencies * Update dependency com.google.cloud:sdk-platform-java-config to v3.29.0 ([#3045](https://togithub.com/googleapis/java-spanner/issues/3045)) ([67a6534](https://togithub.com/googleapis/java-spanner/commit/67a65346d5a01d118d5220230e3bed6db7e79a33)) * Update dependency commons-cli:commons-cli to v1.7.0 ([#3043](https://togithub.com/googleapis/java-spanner/issues/3043)) ([9fea7a3](https://togithub.com/googleapis/java-spanner/commit/9fea7a30e90227e735ad3595f4ca58dfb1ca1b93)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a storm of requests for sessions leads to the session pool being temporarily exhausted, the session pool will return RESOURCE_EXHAUSTED errors for those requests. That error was however not propagated to any additional threads that were also waiting for the same transaction, and would cause these threads to continue with the transaction even though no valid session had been assigned. This fix ensures that the exception is also propagated to any thread waiting for the session.