Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make SessionPoolOptions#setUseMultiplexedSession(boolean) package private #3130

Merged
merged 3 commits into from
May 29, 2024
Merged

fix: make SessionPoolOptions#setUseMultiplexedSession(boolean) package private #3130

merged 3 commits into from
May 29, 2024

Conversation

harshachinta
Copy link
Contributor

@harshachinta harshachinta commented May 29, 2024 •
edited by olavloite
Loading

The SessionPoolOptions#setUseMultiplexedSessions(boolean) method was made public by accident. This method is not intended for public use.

@harshachinta harshachinta requested a review from a team as a code owner May 29, 2024 05:39
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels May 29, 2024
@harshachinta harshachinta requested a review from a team as a code owner May 29, 2024 05:53
@harshachinta harshachinta added the owlbot:run Add this label to trigger the Owlbot post processor. label May 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 29, 2024
olavloite
olavloite requested changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should change the PR title

@olavloite olavloite changed the title chore(spanner): make multiplexedsession setter package private fix: make SessionPoolOptions#setUseMultiplexedSession(boolean) package private May 29, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels May 29, 2024
olavloite
olavloite approved these changes May 29, 2024
View reviewed changes
Copy link
Collaborator

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took the liberty of changing the PR title and description, so that it shows up in the release notes and triggers a new patch version (chore: is not a releasable unit).

@harshachinta harshachinta merged commit 575c3e0 into googleapis:main May 29, 2024
32 checks passed
@release-please release-please bot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshachinta @olavloite