Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check generation for nullability before incrementing it #888

Merged
merged 2 commits into from Apr 20, 2022

Conversation

domrde
Copy link
Contributor

@domrde domrde commented Apr 19, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #886 ☕️

@domrde domrde requested a review from a team as a code owner April 19, 2022 15:37
@google-cla
Copy link

google-cla bot commented Apr 19, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 19, 2022
@BenWhitehead BenWhitehead added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2022
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage-nio API. label Apr 20, 2022
@domrde
Copy link
Contributor Author

domrde commented Apr 20, 2022

Hey, @BenWhitehead, am I doing something wrong? Why clirr is failing?

@BenWhitehead BenWhitehead added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 20, 2022
@BenWhitehead
Copy link
Collaborator

@domrde I'm not sure why it's failing. It looks like some transient failure downloading jars during the build.

I've manually ran clirr against this PR and verified it does not error. I'll merge shortly.

@BenWhitehead BenWhitehead merged commit cadf081 into googleapis:main Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage-nio API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FakeStorageRpc: NPE on copying file
3 participants