Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for disabling client-side validation in V4 Post Policy #1178

Closed
4 tasks
frankyn opened this issue Dec 14, 2021 · 2 comments · Fixed by #1210
Closed
4 tasks

Allow for disabling client-side validation in V4 Post Policy #1178

frankyn opened this issue Dec 14, 2021 · 2 comments · Fixed by #1210
Assignees
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Member

frankyn commented Dec 14, 2021

When calling validateFields; it checks to make sure provided input field keys are part of a known list. This is restrictive on input and would require an update if we introduce more fields in the future (which is possible).

Follow-up:

  • Does the server return a useful error?
  • Is the error state opaque such that the server can't return a better error?
  • If the server can be improved should we advocate that?
  • If the server error can only be opaque, do we want to introduce a strict/relaxed validation option? strict: throw exception or relaxed: log a warning for customer
@frankyn frankyn added this to the Remove client side validation milestone Dec 14, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Dec 14, 2021
@frankyn frankyn added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 14, 2021
@frankyn
Copy link
Member Author

frankyn commented Jan 10, 2022

@JesseLovelace are you still looking at this issue?

@JesseLovelace
Copy link
Contributor

JesseLovelace commented Jan 20, 2022

The server gives a 400 bad request with the following message:

<?xml version='1.0' encoding='UTF-8'?><Error><Code>InvalidPolicyDocument</Code><Message>The content of the form does not meet the conditions specified in the policy document.</Message><Details>Invalid exact match name: invalid</Details></Error>

This should be sufficient for debugging, so we'll remove the validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants