Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update BucketInfo.LifecycleRule#fromPb to wire through MatchesPrefix & MatchesSuffix #1717

Merged
merged 2 commits into from
Oct 18, 2022

Conversation

sundarrajanraman
Copy link
Contributor

@sundarrajanraman sundarrajanraman commented Oct 18, 2022

fix: Fixing the issue of MatchPrefix and Matchsuffix properties set in the GCP Console not being picked up by the API (BucketInfo).

Fixes #1715 ☕️

If you write sample code, please follow the samples format.

@sundarrajanraman sundarrajanraman requested a review from a team as a code owner October 18, 2022 18:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Oct 18, 2022
@BenWhitehead BenWhitehead changed the title fix for the issue MatchPrefix and MatchSuffix properties 1715 fix: update BucketInfo.LifecycleRule#fromPb to wire through MatchesPrefix & MatchesSuffix Oct 18, 2022
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Oct 18, 2022

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@BenWhitehead BenWhitehead added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 18, 2022
Copy link
Collaborator

@BenWhitehead BenWhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @sundarrajanraman!

@BenWhitehead BenWhitehead added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 18, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Oct 18, 2022
@BenWhitehead BenWhitehead merged commit eae3cf2 into googleapis:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MatchPrefix and MatchSuffix properties created from the UI, are not reflecting in the LifecycleCondition
3 participants