Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Storage-NIO library into this repository. #242

Closed
frankyn opened this issue Apr 13, 2020 · 4 comments · Fixed by #351
Closed

Merge Storage-NIO library into this repository. #242

frankyn opened this issue Apr 13, 2020 · 4 comments · Fixed by #351
Assignees
@frankyn @dmitry-fa
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Member

frankyn commented Apr 13, 2020

Currently have two repositories that must be merged into one library.

https://github.com/googleapis/java-storage-nio needs to be merged into this repository to unblock changes to the underlying internal only StorageRpc interface. Otherwise we can accidentally break users.
@frankyn frankyn self-assigned this Apr 13, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 13, 2020
@frankyn frankyn changed the title Merge Storage-NIO library into Storage repository. Merge Storage-NIO library into this repository. Apr 13, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 14, 2020
@frankyn frankyn added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Apr 20, 2020
@frankyn
Copy link
Member Author

frankyn commented Apr 20, 2020

After discussing with @chingor13, the more likely approach is to separate out testing related code used by the Storage-Nio library into a separate artifact called google-cloud-storage-testing instead of merging Storage-NIO library into this repository.

@frankyn frankyn added status: investigating The issue is under investigation, which is determined to be non-trivial. and removed 🚨 This issue needs some love. labels Apr 20, 2020
@dmitry-fa
Copy link
Contributor

@frankyn, I this is about exporting FakeStorageRpc for the sake of testing I can take care of this issue to move it on. #202 and #179 are currently blocked by this issue.

@dmitry-fa dmitry-fa mentioned this issue Jun 2, 2020
Closed
@dmitry-fa
Copy link
Contributor

Suggested fix #345 creates a copy of FakeStorageRpc from Storage-Nio in Storage. Because the main storage artifact already includes a testing package (com.google.cloud.storage.testing) the new class is placed there. No extra artifact is required.

I verified, Storage-Nio could switch to the new FakeStorageRpc class without adding extra dependencies.

@dmitry-fa dmitry-fa mentioned this issue Jun 5, 2020
Merged
@dmitry-fa dmitry-fa self-assigned this Jun 8, 2020
@dmitry-fa
Copy link
Contributor

FakeStorageRpc from #345 is very NIO specific, unlikely it will be used by anyone else. #351 provides a more generic approach: StorageRpcTestBase class implementing StorageRpc. FakeStorageRpc can extend StorageRpcTestBase.

cc: @frankyn

@dmitry-fa dmitry-fa mentioned this issue Jun 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankyn frankyn

@dmitry-fa dmitry-fa

Labels
api: storage Issues related to the googleapis/java-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. status: investigating The issue is under investigation, which is determined to be non-trivial. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
3 participants
@frankyn @yoshi-automation @dmitry-fa