Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Mockito dependency #283

Closed
dmitry-fa opened this issue Apr 28, 2020 · 3 comments · Fixed by #284
Closed

feat: Add Mockito dependency #283

dmitry-fa opened this issue Apr 28, 2020 · 3 comments · Fixed by #284
Assignees
@dmitry-fa
Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@dmitry-fa
Copy link
Contributor

Google requires new tests to use Mockito even if existing tests use EasyMock.
@dmitry-fa dmitry-fa self-assigned this Apr 28, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 28, 2020
@dmitry-fa dmitry-fa mentioned this issue Apr 28, 2020
Merged
@frankyn frankyn added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 28, 2020
@frankyn
Copy link
Member

frankyn commented Apr 28, 2020

We will need to add an AI to address existing tests as well.

@dmitry-fa
Copy link
Contributor Author

@frankyn, do you mean #270 ?

@frankyn
Copy link
Member

frankyn commented Apr 28, 2020

If it was relabeld to Update EasyMock tests to use Mockito feature request. Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitry-fa dmitry-fa

Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add mockito dependency dmitry-fa/java-storage
2 participants
@frankyn @dmitry-fa