feat: support adding and deleting from MySQLVectorStore #53
Conversation
product-auto-label
bot
added
the
api: cloudsql-mysql
| self, | ||
| ids: Optional[List[str]] = None, | ||
| **kwargs: Any, | ||
| ) -> Optional[bool]: |
There was a problem hiding this comment.
not sure why this return type is optional Optional[bool] but that is what Postgres had... 🤷♂️
There was a problem hiding this comment.
This matches the VS interface (https://github.com/langchain-ai/langchain/blob/master/libs/core/langchain_core/vectorstores.py#L88). Should we change it to just bool?
There was a problem hiding this comment.
Thanks for the link! I think the VS interface is basically just saying subclasses can choose to return True or return None for successfully deleted items. Leaving it up to the individual implementations to decide which approach they prefer. Since we are returning True/False with no path that returns None I've updated the return type to be -> bool to make this clear to users.
| self, | ||
| ids: Optional[List[str]] = None, | ||
| **kwargs: Any, | ||
| ) -> Optional[bool]: |
There was a problem hiding this comment.
This matches the VS interface (https://github.com/langchain-ai/langchain/blob/master/libs/core/langchain_core/vectorstores.py#L88). Should we change it to just bool?
Add support for
.add_documentsand.deleteMySQLVector methods.