Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add index types for vector search #55

Merged
merged 8 commits into from
Mar 28, 2024
Merged

feat: add index types for vector search #55

merged 8 commits into from
Mar 28, 2024

Conversation

totoleon
Copy link
Contributor

Adding index operations and tests

@totoleon totoleon requested a review from a team as a code owner March 27, 2024 20:30
@product-auto-label product-auto-label bot added the api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API. label Mar 27, 2024
@totoleon totoleon changed the title feat: adding index and test feat: adding index and tests Mar 27, 2024
jackwotherspoon
jackwotherspoon reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just making a quick pass, let's make sure to add a detailed description to this PR maybe with some sample usage

src/langchain_google_cloud_sql_mysql/__init__.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/engine.py Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/indexes.py Outdated Show resolved Hide resolved
src/langchain_google_cloud_sql_mysql/indexes.py Outdated Show resolved Hide resolved
@jackwotherspoon jackwotherspoon changed the title feat: adding index and tests feat: add index types for vector search Mar 27, 2024
jackwotherspoon
jackwotherspoon approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totoleon totoleon merged commit 2e30b48 into main Mar 28, 2024
11 checks passed
@totoleon totoleon deleted the vector-index branch March 28, 2024 18:15
@release-please release-please bot mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

Assignees
No one assigned
Labels
api: cloudsql-mysql Issues related to the googleapis/langchain-google-cloud-sql-mysql-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@totoleon @averikitsch @jackwotherspoon