fix: samples and tests updated #13

ikuleshov · 2020-07-29T09:12:05Z

Samples fixed and updated to use the correct client library.
Integration test added.

codecov · 2020-07-29T09:15:50Z

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files           5        5           
  Lines        6478     6478           
  Branches      241      241           
=======================================
  Hits         6362     6362           
  Misses        115      115           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b2cebf...528394b. Read the comment docs.

bcoe

A couple notes, and looks like we could use a rebase.

samples/package.json

samples/quickstart_installed_oauth2.js

Samples fixed and updated to use the correct client library. Integration test added.

…tics-admin into analytics-samples

bcoe · 2020-08-03T21:29:05Z

@ikuleshov thank you for the cleanup, this is looking great.

🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.1](https://www.github.com/googleapis/nodejs-analytics-admin/compare/v1.1.0...v1.1.1) (2020-08-04) ### Bug Fixes * samples and tests updated ([#13](https://www.github.com/googleapis/nodejs-analytics-admin/issues/13)) ([55f4366](https://www.github.com/googleapis/nodejs-analytics-admin/commit/55f4366d75a09b697ac1b7d1ef416cf27448832a)) * **docs:** update docs with current samples ([24a452c](https://www.github.com/googleapis/nodejs-analytics-admin/commit/24a452c9472f521e8164911ba4f8e2a3d77e2fca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).

google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 29, 2020

bcoe suggested changes Jul 29, 2020

View reviewed changes

samples/package.json Outdated Show resolved Hide resolved

samples/quickstart_installed_oauth2.js Show resolved Hide resolved

ikuleshov requested a review from bcoe July 31, 2020 21:09

fix: samples and tests updated

46f5560

Samples fixed and updated to use the correct client library. Integration test added.

sofisl added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 3, 2020