This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Samples won't properly capture exceptions #242
Labels
api: cloudasset
Issues related to the googleapis/nodejs-asset API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
🚨
This issue needs some love.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Just throwing this into the backlog after a discussion on nodejs-pubsub.
Specifically looking at this one, but there may be others:
https://github.com/googleapis/nodejs-asset/blob/master/samples/exportAssets.js
Because the call to the inner async function doesn't await, this won't actually catch and pass on exceptions that happen inside of it, and it'll get an unhandled rejection warning from Node. Simpler repro example:
The text was updated successfully, but these errors were encountered: