This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: add minimum wrapper for compute LRO method #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: compute
alexander-fenster
approved these changes
Sep 8, 2021
bcoe
approved these changes
Sep 8, 2021
bcoe
suggested changes
Sep 10, 2021
bcoe
approved these changes
Sep 13, 2021
This was referenced Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Owlbot is not ready to use at this moment. Manual copy paste the generated source code.
@google-cloud/gapic-generator v2.5.0
gapic-generator-typescript enables diregapic (compute) library add a minimum wrapper for LRO operation googleapis/gapic-generator-typescript#967
Manually update the surface using the v2.5.0 generator.
System-test failed on the LRO change, because it referred to the
google.cloud.compute.v1.Operation.targetLinkwhere we don't expose in the wrapper. To fix it, we refer toinsertOp.latestResponse.targetLinkinstanceTemplate: insertOp.targetLink, ->instanceTemplate: insertOp.latestResponse.targetLink,Alternative approach is add
targetLinkin the wrapper PR. However, the gax Operation has no this field. The downside is we could not remove this field once it publish because it will be a breaking change.