feat: Include expiresAt in Datastore to allow TTL #317
Conversation
Added expiresAt to the data stored. Value will be a date object of the creation time plus expirationMs.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
product-auto-label
bot
added
size: xs
gbowman85
changed the title
|
@gbowman85 thank you for the contribution 馃憦 Reading the documentation linked in #314, it wasn't clear to me that setting If we can set a TTL directly in datastore now, I think we could remove logic from this library that handles the TTL. |
"expiresAt" is not a key term, I was just following the same format as was used in the library. A property of 'expiresAt' wouldn't automatically trigger a TTL, but it does allow you to create one using the method in the documentation: https://cloud.google.com/datastore/docs/ttl#create_ttl_policy |
|
Anything I can do to help move this forward? @bcoe |
Added expiresAt to the data stored. Value will be a date object of the creation time plus expirationMs. This will allow TTL in Datastore to be set.
P.S. This is my first pull request so please go easy on me :)
Fixes #314 馃