fix: Make aggregation query requests run properly inside a transaction #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When doing a readOnly transaction, the code should do reads from a consistent snapshot so that if a write is done mid-transaction then that doesn’t affect the read value.
This code change ensures transactions that run aggregate queries actually make the request as an aggregate query.
Verify run query results at a particular time so that we know what data we are working with for the rest of the aggregate query tests.
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: m
kolea2
approved these changes
Oct 3, 2023
danieljbruce
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This PR ensures that transaction reads work for run aggregation query requests. Currently, when a user uses the transaction object to run an aggregation query request then the aggregation query request does not run inside the transaction. This fix ensures that the request does run inside a transaction.
Fixes #1151