Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I want to know which properties of the retrieved entity are excluded from the index. #935

Open
malt03 opened this issue Apr 19, 2022 · 4 comments
Open

I want to know which properties of the retrieved entity are excluded from the index. #935

malt03 opened this issue Apr 19, 2022 · 4 comments
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@malt03
Copy link

malt03 commented Apr 19, 2022

Is your feature request related to a problem? Please describe.
I want to know which properties of the retrieved entity are excluded from the index.
Describe the solution you'd like
Allow the value of exclude_from_indexes, defined in Protocol buffer, to be retrieved through the library.
Describe alternatives you've considered
None.
Additional context
None.
@malt03 malt03 added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 19, 2022
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Apr 19, 2022
@malt03
Copy link
Author

malt03 commented Apr 19, 2022

main...mish-tv:main

I believe that adding a new EXCLUDE_FROM_INDEXES_SYMBOL and adding a value to the entity object would add feature with less scope of influence.

@meredithslota meredithslota removed the priority: p3 Desirable enhancement or fix. May not be included in next release. label Jul 20, 2022
@calsmith calsmith mentioned this issue May 22, 2023
Open
@calsmith
Copy link

Related request: #1111

@danieljbruce
Copy link
Contributor

When you say the retrieved entity then are you referring to when datastore.get is used or when datastore.runQuery is used?

@danieljbruce
Copy link
Contributor

I can confirm that entity.properties at

nodejs-datastore/src/request.ts

Line 309 in ba8ea83

if (err) {
includes an excludeFromIndexes field so I think this can be included here. We just need to parse it properly in this function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@malt03 @meredithslota @calsmith @danieljbruce