-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add the count aggregate function #972
Merged
danieljbruce
merged 76 commits into
googleapis:main
from
danieljbruce:count-aggregation-only-relevant-changes
Jan 12, 2023
Merged
feat: Add the count aggregate function #972
danieljbruce
merged 76 commits into
googleapis:main
from
danieljbruce:count-aggregation-only-relevant-changes
Jan 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1b21ec2.
…hub.com/danieljbruce/nodejs-datastore into count-aggregation-only-relevant-changes
Mariatta
reviewed
Jan 10, 2023
src/aggregate.ts
Outdated
Comment on lines
15
to
17
// ** This file is automatically generated by gapic-generator-typescript. ** | ||
// ** https://github.com/googleapis/gapic-generator-typescript ** | ||
// ** All changes to this file may be overwritten. ** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the notice correct that this is autogenerated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not autogenerated. Thanks for catching this one! Changes pushed.
…hub.com/danieljbruce/nodejs-datastore into count-aggregation-only-relevant-changes
kolea2
previously requested changes
Jan 11, 2023
ruyadorno
approved these changes
Jan 12, 2023
Mariatta
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: datastore
Issues related to the googleapis/nodejs-datastore API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is just like the other PR on count aggregation, but it contains only the relevant changes to make the count filter work.