Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: automatically use service and revision name in Knative environments #375

Merged
merged 7 commits into from
Jun 19, 2019

Conversation

DominicKramer
Copy link
Contributor

Fixes #370

@DominicKramer DominicKramer requested review from a team June 18, 2019 18:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2019
@codecov
Copy link

codecov bot commented Jun 18, 2019

Codecov Report

Merging #375 into master will increase coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   92.19%   92.57%   +0.37%     
==========================================
  Files          21       21              
  Lines        3140     3151      +11     
  Branches      328      327       -1     
==========================================
+ Hits         2895     2917      +22     
+ Misses        241      230      -11     
  Partials        4        4
Impacted Files Coverage Δ
src/configuration.ts 94.58% <100%> (+0.12%) ⬆️
src/google-apis/auth-client.ts 96.66% <0%> (+4.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3ae66...c3ac6b4. Read the comment docs.

@DominicKramer DominicKramer merged commit 453bd6e into googleapis:master Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library should automatically pick up service and revision name in Knative environments
3 participants