Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return errors from Query.stream() #1046

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This makes sure that we return an error from the Query stream() even if we were able to deliver an initial set of query results.

Fixes #964

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 25, 2020
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #1046 into master will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1046      +/-   ##
==========================================
- Coverage   97.58%   97.46%   -0.12%     
==========================================
  Files          25       25              
  Lines       16015    16015              
  Branches     1294     1219      -75     
==========================================
- Hits        15628    15609      -19     
- Misses        384      403      +19     
  Partials        3        3              
Impacted Files Coverage Δ
dev/src/reference.ts 99.80% <100.00%> (-0.08%) ⬇️
dev/src/order.ts 98.09% <0.00%> (-1.15%) ⬇️
dev/src/pool.ts 97.75% <0.00%> (-0.90%) ⬇️
dev/src/transaction.ts 96.47% <0.00%> (-0.51%) ⬇️
dev/src/watch.ts 98.77% <0.00%> (-0.37%) ⬇️
dev/src/document.ts 98.65% <0.00%> (-0.29%) ⬇️
dev/src/serializer.ts 98.77% <0.00%> (-0.25%) ⬇️
dev/src/validate.ts 98.05% <0.00%> (-0.25%) ⬇️
dev/src/index.ts 98.62% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d13b9a6...4bbe9d2. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 4b65fca into master Apr 25, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/dontswallow branch April 25, 2020 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

query.stream() time out with Error: 14 UNAVAILABLE after 60 sec
5 participants