fix: Add BulkWriter #1051
Merged
fix: Add BulkWriter #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 9, 2020 12:33
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1051 +/- ##
==========================================
- Coverage 97.58% 97.48% -0.10%
==========================================
Files 25 27 +2
Lines 16015 16860 +845
Branches 1295 1261 -34
==========================================
+ Hits 15628 16436 +808
- Misses 384 420 +36
- Partials 3 4 +1
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
This came together nicely. I have three small requests before merging:
- Address the one comment nit in this PR.
- Verify that the output of
yarn docsdoesn't contain any snippets that should be hidden. It might be a good idea to do a general scrub of the documentation thatyarn docswrites to./docs. - Change the PR title to make sure this is not a minor version bump and to not overpromise in our release notes. We were not actually able to add a new feature - just a bunch of amazing looking code :)
| * .then(res => { | ||
| * console.log(`Deleted document at ${res.writeTime}`); | ||
| * }); | ||
| * await bulkWriter.flush().then(() => { |
There was a problem hiding this comment.
Nit: Make this bulkWriter.close() and remove line 678.
|
Regenerated the docs and verified that no globals or classes leaked. Thanks so much for helping shepherd this through Sebastian! |
thebrianchen
pushed a commit
that referenced
this pull request
Apr 28, 2020
This reverts commit 8c52d47.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping fields private until protos are publicly released.