fix: return null for 'parent' call on root collection #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/parent
branch
from
404680f
to
e84dc2f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1099 +/- ##
==========================================
- Coverage 97.61% 97.48% -0.13%
==========================================
Files 27 27
Lines 16970 16974 +4
Branches 1351 1270 -81
==========================================
- Hits 16565 16547 -18
- Misses 402 423 +21
- Partials 3 4 +1
Continue to review full report at Codecov.
|
thebrianchen
approved these changes
May 30, 2020
| get parent(): DocumentReference<DocumentData> { | ||
| return new DocumentReference(this.firestore, this._queryOptions.parentPath); | ||
| get parent(): DocumentReference<DocumentData> | null { | ||
| if (this._queryOptions.parentPath.isDocument) { |
There was a problem hiding this comment.
isDocument is a property (typed a get isDocument()). As such, no parenthesis are needed.
There was a problem hiding this comment.
Thanks for the review. Fortunately, this is not a breaking change:
- The method is already typed to return null (in the firestore.d.ts types). I will also update the JSDoc.
- This caused an "NPE" in our code before, so this was already broken (that's the issue that was filed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to return "null" for the parent call in a root collection.
Also noticed that our Path.isEqual doesn't work correctly since it considers QualifiedResourcePaths and ResourcePaths as non-equal. Our typings already ensure that a FieldPath and a ResourcePath can never be compared for equality.
Fixes #1098