-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix flaky BulkWriter test #1115
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 97.40% 98.61% +1.20%
==========================================
Files 27 28 +1
Lines 16978 18301 +1323
Branches 1271 1405 +134
==========================================
+ Hits 16538 18047 +1509
+ Misses 436 251 -185
+ Partials 4 3 -1
Continue to review full report at Codecov.
|
9ca8adf
to
3517377
Compare
Fix LGTM. I think we should fix in master since #1097 is against master. |
5b91fa5
to
2a9a25f
Compare
schmidt-sebastian
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1097.
I couldn't reproduce this locally, but my hypothesis is that the test had floating promises that resulted in race conditions. If the second
flush()
call was made before the firstflush()
call sent its request, the rate limit threshold would not have have been reached for the secondflush()
, which meant the timeout handler that ended the test would never be invoked.By waiting for promises to complete instead of using
done()
, the test should now execute in the correct order each time.