fix: retry Query streams #1116
Merged
fix: retry Query streams #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
wilhuff
approved these changes
Jun 8, 2020
dev/src/reference.ts
Outdated
|
|
||
| let active = true; | ||
| while (active) { | ||
| const deferred = new Deferred<boolean>(); |
There was a problem hiding this comment.
What condition does deferred represent? Naming this something that ties it to its meaning more than its type would be helpful. Based on my read it seems like maybe shouldRetry, retryRequired, or something like that?
There was a problem hiding this comment.
I merged this with the active flag and renamed to streamActive.
…-firestore into mrschmidt/retrystreams
This was referenced Jun 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the ideas I discussed with clem@ on how to make Query streams more robust. Basically, we can restart a stream with the last received document as the cursor.