feat: make BulkWriter public #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1252 +/- ##
==========================================
- Coverage 98.50% 98.50% -0.01%
==========================================
Files 30 30
Lines 18632 18620 -12
Branches 1431 1431
==========================================
- Hits 18353 18341 -12
Misses 276 276
Partials 3 3
Continue to review full report at Codecov.
|
schmidt-sebastian
approved these changes
Jun 30, 2020
| * An options object that can be used to disable request throttling in | ||
| * BulkWriter. | ||
| */ | ||
| export interface BulkWriterOptions { |
There was a problem hiding this comment.
Please remove
nodejs-firestore/dev/src/types.ts
Line 154 in 56355f1
schmidt-sebastian
added
the
do not merge
schmidt-sebastian
removed
the
do not merge
schmidt-sebastian
approved these changes
Jul 7, 2020
sk-
pushed a commit
to sk-/nodejs-firestore
that referenced
this pull request
Jul 23, 2020
This method was missing in PR googleapis#1252
This was referenced Jul 23, 2020
sk-
pushed a commit
to sk-/nodejs-firestore
that referenced
this pull request
Jul 23, 2020
This method was missing in PR googleapis#1252
schmidt-sebastian
pushed a commit
that referenced
this pull request
Jul 24, 2020
This method was missing in PR #1252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.