fix: add Firestore.bulkWriter to firestore.d.ts #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
sk-
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1272 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 30 30
Lines 18612 18612
Branches 1339 1431 +92
=======================================
Hits 18333 18333
Misses 276 276
Partials 3 3 Continue to review full report at Codecov.
|
thebrianchen
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Thanks for spotting this and submitting a PR! lgtm
@schmidt-sebastian Can you merge the PR into master?
schmidt-sebastian
approved these changes
Jul 23, 2020
This method was missing in PR googleapis#1252
schmidt-sebastian
added
the
kokoro:run
yoshi-kokoro
removed
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method was missing in PR #1252
Fixes #1271