Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for != and not-in queries #1292

Merged
merged 6 commits into from
Sep 8, 2020
Merged

feat: add support for != and not-in queries #1292

merged 6 commits into from
Sep 8, 2020

Conversation

thebrianchen
Copy link

Will merge once feature is released in client SDKs.

@thebrianchen thebrianchen requested review from a team as code owners August 28, 2020 19:19
@thebrianchen thebrianchen self-assigned this Aug 28, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 28, 2020
@thebrianchen thebrianchen added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 28, 2020
schmidt-sebastian
schmidt-sebastian approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to release this next week.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Aug 29, 2020
@thebrianchen thebrianchen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 31, 2020
@thebrianchen thebrianchen mentioned this pull request Aug 31, 2020
Merged
@codecov
Copy link

codecov bot commented Sep 8, 2020 •
edited
Loading

Codecov Report

Merging #1292 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1292   +/-   ##
=======================================
  Coverage   98.50%   98.50%           
=======================================
  Files          30       30           
  Lines       18660    18669    +9     
  Branches     1434     1440    +6     
=======================================
+ Hits        18381    18390    +9     
  Misses        276      276           
  Partials        3        3
Impacted Files Coverage Δ
dev/src/reference.ts 99.88% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e019021...46c7dff. Read the comment docs.

@thebrianchen thebrianchen removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 8, 2020
@thebrianchen thebrianchen merged commit 786e52f into master Sep 8, 2020
@thebrianchen thebrianchen deleted the bc/ne branch September 8, 2020 23:07
@HemangChothani HemangChothani mentioned this pull request Sep 17, 2020
Closed
@laljikanjareeya laljikanjareeya mentioned this pull request Sep 18, 2020
Merged
@quartzmo quartzmo mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thebrianchen @schmidt-sebastian @yoshi-kokoro