fix: retry transactions that fail with expired transaction IDs #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
schmidt-sebastian
force-pushed
the
mrschmidt/expiredtransactions
branch
from
d8726c5
to
2caba46
Compare
Codecov Report
@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
+ Coverage 98.49% 98.54% +0.04%
==========================================
Files 32 32
Lines 19109 19115 +6
Branches 1370 1373 +3
==========================================
+ Hits 18822 18836 +14
+ Misses 284 276 -8
Partials 3 3
Continue to review full report at Codecov.
|
product-auto-label
bot
added
the
api: firestore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/171204289
The original issue is that once a transaction expires, the backend returns INVALID_ARGUMENT. While INVALID_ARGUMENT is not generally retryable, we want to retry INVALID_ARGUMENT for expired transactions only. After talking with the backend TL, we decided that we can only do this based on the error message and if we have previously received a transaction ID.
This PR also changes the Rollback RPC to use the same retry semantics.