Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not modify options object, use defaultScopes #1360

Merged
merged 3 commits into from
Nov 7, 2020

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Nov 6, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1360 (cc7d10c) into master (b5cf449) will decrease coverage by 0.01%.
The diff coverage is 98.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1360      +/-   ##
==========================================
- Coverage   98.54%   98.53%   -0.02%     
==========================================
  Files          32       32              
  Lines       19194    19375     +181     
  Branches     1377     1367      -10     
==========================================
+ Hits        18915    19091     +176     
- Misses        276      280       +4     
- Partials        3        4       +1     
Impacted Files Coverage Δ
dev/src/v1beta1/firestore_client.ts 97.79% <98.11%> (+0.02%) ⬆️
dev/src/v1/firestore_admin_client.ts 98.81% <98.32%> (-0.03%) ⬇️
dev/src/v1/firestore_client.ts 98.09% <98.44%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cf449...ad45de6. Read the comment docs.

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@alexander-fenster alexander-fenster merged commit bd40d3a into master Nov 7, 2020
@alexander-fenster alexander-fenster deleted the ggt-1.2.1 branch November 7, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants