fix: stop using GRPC channels after RST_STREAM #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: firestore
schmidt-sebastian
force-pushed
the
mrschmidt/rststream
branch
from
629507b
to
ad06daf
Compare
Codecov Report
@@ Coverage Diff @@
## master #1373 +/- ##
==========================================
- Coverage 98.51% 98.51% -0.01%
==========================================
Files 32 32
Lines 19440 19464 +24
Branches 1371 1375 +4
==========================================
+ Hits 19152 19174 +22
- Misses 284 286 +2
Partials 4 4
Continue to review full report at Codecov.
|
dev/src/pool.ts
Outdated
| @@ -140,10 +149,19 @@ export class ClientPool<T> { | |||
| * @private | |||
| */ | |||
| private shouldGarbageCollectClient(client: T): boolean { | |||
| // Don't garbagae collect clients that have active requests. | |||
alexander-fenster
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on a theory (based on some anecdotal evidence) that once a GRPC Channel receives the first RST_STREAM error it will only every throw RST_STREAM errors. This PR changes our client pool to mark any GAX client that throws RST_STREAM as failed and ensures that the SDK spins up a new client for the next request.
Addresses #1023