fix: Use Array.isArray instead of an instanceof check
#1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: firestore
google-cla
bot
added
the
cla: yes
var-const
force-pushed
the
varconst/use-isarray
branch
from
5d1542a
to
bb8c645
Compare
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
=======================================
Coverage 98.50% 98.50%
=======================================
Files 32 32
Lines 19392 19392
Branches 1362 1362
=======================================
Hits 19102 19102
Misses 286 286
Partials 4 4
Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Feb 6, 2021
JustinBeckwith
changed the title
Array.isArray instead of an instanceof checkArray.isArray instead of an instanceof check
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Feb 9, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [4.9.3](https://www.github.com/googleapis/nodejs-firestore/compare/v4.9.2...v4.9.3) (2021-02-09) ### Bug Fixes * use `Array.isArray` instead of an `instanceof` check ([#1417](https://www.github.com/googleapis/nodejs-firestore/issues/1417)) ([4a8c3cf](https://www.github.com/googleapis/nodejs-firestore/commit/4a8c3cfcaf57ed600da094ab0275a5f32fb1ea30)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code already relies on
isArraywhereas theinstanceofcheck may fail when the array was created in a different module (as detailed in the linked issue).Fixes #1409