fix: save negative zero as doubleValue #1639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: no
product-auto-label
bot
added
the
api: firestore
|
Thanks for the PR! Could you (a) sign the CLA (see |
google-cla
bot
added
cla: yes
Yonom
changed the title
|
You can ignore the "Auto-approve.yml check" failed check. This looks good to me, but I'm going to get my colleague with more experience in this particular GitHub repository to provide formal approval. Thanks for taking the time to submit this fix! |
|
@schmidt-sebastian Can you take a look at this PR? It LGTM but wanted a 2nd opinion. |
|
Awesome. Thank you for the quick review! 馃槉 |
schmidt-sebastian
approved these changes
Dec 1, 2021
schmidt-sebastian
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
schmidt-sebastian
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Javascript only has a number type while firestore differentiates between int64 and double. Both the Web SDK and the nodejs SDK identify integers to store them appropriately. However, the algorithms between the Web SDK and the nodejs SDK differ in one particular case: the negative zero double value.
Relevant lines of code from the JS SDK:
https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/remote/number_serializer.ts#L56
https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/util/types.ts#L44
This PR aligns the nodejs SDK behavior with the one in the Web SDK.
Template
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Appropriate docs were updated (if necessary)Fixes #1638 馃