Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable REST numeric enums #1829

Merged
merged 3 commits into from
Feb 28, 2023
Merged

fix: enable REST numeric enums #1829

merged 3 commits into from
Feb 28, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 28, 2023

  • Regenerate this pull request now.

To use REST transport, pass {fallback: "rest"} to the client constructor.

PiperOrigin-RevId: 512747300

Source-Link: googleapis/googleapis@b0f2af1

Source-Link: https://github.com/googleapis/googleapis-gen/commit/c98698490eab76032d20606e214d310394e7930e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzk4Njk4NDkwZWFiNzYwMzJkMjA2MDZlMjE0ZDMxMDM5NGU3OTMwZSJ9

To use REST transport, pass {fallback: "rest"} to the client constructor.

PiperOrigin-RevId: 512747300

Source-Link: googleapis/googleapis@b0f2af1

Source-Link: googleapis/googleapis-gen@c986984
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzk4Njk4NDkwZWFiNzYwMzJkMjA2MDZlMjE0ZDMxMDM5NGU3OTMwZSJ9
@gcf-owl-bot gcf-owl-bot bot requested review from a team as code owners February 28, 2023 02:20
@snippet-bot
Copy link

snippet-bot bot commented Feb 28, 2023

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Feb 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xl Pull request size is extra large. labels Feb 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 28, 2023
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 28, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 28, 2023
@alexander-fenster alexander-fenster changed the title feat(typescript): enable REST transport fix: enable REST numeric enums Feb 28, 2023
@alexander-fenster
Copy link
Contributor

alexander-fenster commented Feb 28, 2023

@MarkDuckworth This enables "numeric enums" feature back since the bug was fixed in google-gax. I'm bumping GAX version in this PR: the bug was fixed in 3.5.4, I'm setting to ^3.5.7 since it's the latest one.

@MarkDuckworth MarkDuckworth merged commit 3737696 into main Feb 28, 2023
@MarkDuckworth MarkDuckworth deleted the owl-bot-copy branch February 28, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. owl-bot-copy size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants