Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Sum and Average aggregations #1873

Merged
merged 14 commits into from Oct 9, 2023
Merged

feat: Sum and Average aggregations #1873

merged 14 commits into from Oct 9, 2023

Conversation

ehsannas
Copy link
Contributor

@ehsannas ehsannas commented Aug 2, 2023

No description provided.

@ehsannas
feat: Sum and Average Aggregations. (#1831)
c0f5022 
* WIP WIP.

* also add isEqual.

* lint.

* add aggregate() API in firestore.d.ts.

* Use NodeJS.Dict

* Update isEqual.

* Add isEqual unit test.

* better api.

* more tests.

* Add more tests.

* Remove test code that targets emulator.

* rename avg() to average().

* rename avg to average.

* Fix lint errors.

* Clean up.

* Address code review comments.

* Expose aggregate type and field publicly.

* Fix the way assert was imported.

* lint.

* backport test updates.
@ehsannas
feat: Add long-alias support for aggregations. (#1844)
f78456b 
* feat: Add long-alias support for aggregations.

* Lint fix and fix unit tests.

* update assertion message.
@ehsannas
Unhide APIs and enable tests (#1869)
36944f8 
* Enable tests.

* Remove @internal annotation.

* Address comments.
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Aug 2, 2023
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 2, 2023
MarkDuckworth
MarkDuckworth approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - two nits for you consideration.

types/firestore.d.ts Outdated Show resolved Hide resolved
dev/system-test/firestore.ts Outdated Show resolved Hide resolved
@ehsannas ehsannas marked this pull request as ready for review September 21, 2023 18:56
@ehsannas ehsannas requested review from a team as code owners September 21, 2023 18:56
@ehsannas ehsannas added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2023
@MarkDuckworth MarkDuckworth mentioned this pull request Oct 3, 2023
Merged
@ehsannas ehsannas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 3, 2023
@ehsannas ehsannas removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2023
@ehsannas ehsannas added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 5, 2023
MarkDuckworth
MarkDuckworth approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehsannas ehsannas merged commit b9ea514 into main Oct 9, 2023
18 checks passed
@ehsannas ehsannas deleted the ehsann/sum-average-release branch October 9, 2023 17:13
@release-please release-please bot mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkDuckworth MarkDuckworth MarkDuckworth approved these changes

@markarndt markarndt markarndt approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehsannas @MarkDuckworth @markarndt @yoshi-kokoro