-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: retry on abort and limit retry count to 10 #655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and solves the problem. I do have a suggestion to simplify it a little bit, and some nits. Thanks Mr Chen!
Thanks for the review mrschmidt! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
95% LGTM!
Please note that this repo now also uses https://www.conventionalcommits.org/
This means that your commit message/PR title drives not only the Changelog but is also used to determine the version of the next release. I would consider this PR a "fix". If you pre-face your commit message with fix
, our GitHub tooling will automatically create a Patch release once this is merged (*)
(*) Note that there is already a feat:
PR that was merged, and as such the patch release will actually be a minor release.
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 61.55% 61.63% +0.07%
==========================================
Files 21 21
Lines 3418 3425 +7
Branches 459 460 +1
==========================================
+ Hits 2104 2111 +7
Misses 1252 1252
Partials 62 62
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #655 +/- ##
==========================================
+ Coverage 61.46% 61.64% +0.17%
==========================================
Files 21 21
Lines 3418 3426 +8
Branches 459 460 +1
==========================================
+ Hits 2101 2112 +11
+ Misses 1254 1252 -2
+ Partials 63 62 -1
Continue to review full report at Codecov.
|
I pushed a small cleanup to this branch to remove the duplicate .catch() clause. Let me know if you disagree otherwise I will merge this tomorrow. Thanks! |
Fixes firebase/firebase-admin-node#478