-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Store large numbers as doubles #683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 96.22% 96.06% -0.17%
==========================================
Files 20 20
Lines 2227 2238 +11
Branches 470 475 +5
==========================================
+ Hits 2143 2150 +7
- Misses 20 21 +1
- Partials 64 67 +3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #683 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 20 20
Lines 2227 2227
Branches 470 470
=======================================
Hits 2143 2143
Misses 20 20
Partials 64 64
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does "right thing", but I think it could be simpler if you took advantage of the ES6 features we get from Node: https://node.green/#ES2015-built-in-extensions-Number-properties-Number-isSafeInteger
Remember to use "conventional commits" in your PR description and in your final commit message. This could be a "fix: Store large numbers as doubles".
Speaking of fixing, you are not just addressing firebase/firebase-admin-node#548, you are fixing it to. If you use one of the following keywords, the original issue will be auto-closed: https://help.github.com/en/articles/closing-issues-using-keywords
You also need to use the "fully-qualified" name of the issue (include firebase/firebase-admin-node
), since you are referring to a different Repo. #number
with no repo name always refers to the current repository.
Fixes firebase/firebase-admin-node#548