Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass x-goog-request-params header for streaming calls #920

Merged
merged 2 commits into from
Feb 7, 2020
Merged

fix: pass x-goog-request-params header for streaming calls #920

merged 2 commits into from
Feb 7, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:

Log from Synthtool 
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/synth.py.
synthtool > Ensuring dependencies.
synthtool > Cloning googleapis.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:47066d295ac6b8a50881a2616aefa075689d27931a8c63bb0f50d62f2b77e3e0
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/admin/v1.
synthtool > Generated code into /tmpfs/tmp/tmp6984pstj.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:47066d295ac6b8a50881a2616aefa075689d27931a8c63bb0f50d62f2b77e3e0
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/v1beta1.
synthtool > Generated code into /tmpfs/tmp/tmp8z9wk1ks.
synthtool > Pulling Docker image: gapic-generator-typescript:latest
latest: Pulling from gapic-images/gapic-generator-typescript
Digest: sha256:47066d295ac6b8a50881a2616aefa075689d27931a8c63bb0f50d62f2b77e3e0
Status: Image is up to date for gcr.io/gapic-images/gapic-generator-typescript:latest
synthtool > Generating code for: google/firestore/v1.
synthtool > Generated code into /tmpfs/tmp/tmpp1zsb40f.
synthtool > Replaced 'return this\\._innerApiCalls\\.listen\\(options\\);' in dev/src/v1beta1/firestore_client.ts.
synthtool > Replaced 'return this\\._innerApiCalls\\.listen\\(options\\);' in dev/src/v1/firestore_client.ts.
.eslintignore
.eslintrc.yml
.github/ISSUE_TEMPLATE/bug_report.md
.github/ISSUE_TEMPLATE/feature_request.md
.github/ISSUE_TEMPLATE/support_request.md
.github/PULL_REQUEST_TEMPLATE.md
.github/release-please.yml
.jsdoc.js
.kokoro/common.cfg
.kokoro/continuous/node10/common.cfg
.kokoro/continuous/node10/docs.cfg
.kokoro/continuous/node10/lint.cfg
.kokoro/continuous/node10/samples-test.cfg
.kokoro/continuous/node10/system-test.cfg
.kokoro/continuous/node10/test.cfg
.kokoro/continuous/node12/common.cfg
.kokoro/continuous/node12/test.cfg
.kokoro/continuous/node8/common.cfg
.kokoro/continuous/node8/test.cfg
.kokoro/docs.sh
.kokoro/lint.sh
.kokoro/presubmit/node10/common.cfg
.kokoro/presubmit/node10/docs.cfg
.kokoro/presubmit/node10/lint.cfg
.kokoro/presubmit/node10/samples-test.cfg
.kokoro/presubmit/node10/system-test.cfg
.kokoro/presubmit/node10/test.cfg
.kokoro/presubmit/node12/common.cfg
.kokoro/presubmit/node12/test.cfg
.kokoro/presubmit/node8/common.cfg
.kokoro/presubmit/node8/test.cfg
.kokoro/presubmit/windows/common.cfg
.kokoro/presubmit/windows/test.cfg
.kokoro/publish.sh
.kokoro/release/docs.cfg
.kokoro/release/docs.sh
.kokoro/release/publish.cfg
.kokoro/samples-test.sh
.kokoro/system-test.sh
.kokoro/test.bat
.kokoro/test.sh
.kokoro/trampoline.sh
.nycrc
.prettierignore
.prettierrc
CODE_OF_CONDUCT.md
CONTRIBUTING.md
LICENSE
README.md
codecov.yaml
renovate.json
samples/README.md
synthtool > Replaced "/protos/protos'" in dev/src/v1/firestore_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore-v1.ts.
synthtool > Replaced "/protos/protos'" in dev/src/v1/firestore_admin_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore_admin-v1.ts.
synthtool > Replaced "/protos/protos'" in dev/src/v1beta1/firestore_client.ts.
synthtool > Replaced "/protos/protos'" in dev/test/gapic-firestore-v1beta1.ts.
npm WARN npm npm does not support Node.js v12.15.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/
npm WARN deprecated @types/moment@2.13.0: This is a stub types definition for Moment (https://github.com/moment/moment). Moment provides its own type definitions, so you don't need @types/moment installed!

> protobufjs@6.8.8 postinstall /tmpfs/src/git/autosynth/working_repo/node_modules/protobufjs
> node scripts/postinstall


> @google-cloud/firestore@3.5.0 prepare /tmpfs/src/git/autosynth/working_repo
> npm run compile

npm WARN npm npm does not support Node.js v12.15.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/firestore@3.5.0 compile /tmpfs/src/git/autosynth/working_repo
> tsc -p .

dev/src/v1/firestore_client.ts:852:19 - error TS2552: Cannot find name 'request'. Did you mean 'Request'?

852       'database': request.database || '',
                      ~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:12776:13
    12776 declare var Request: {
                      ~~~~~~~
    'Request' is declared here.

dev/src/v1/firestore_client.ts:876:19 - error TS2552: Cannot find name 'request'. Did you mean 'Request'?

876       'database': request.database || '',
                      ~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:12776:13
    12776 declare var Request: {
                      ~~~~~~~
    'Request' is declared here.

dev/src/v1beta1/firestore_client.ts:860:19 - error TS2552: Cannot find name 'request'. Did you mean 'Request'?

860       'database': request.database || '',
                      ~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:12776:13
    12776 declare var Request: {
                      ~~~~~~~
    'Request' is declared here.

dev/src/v1beta1/firestore_client.ts:884:19 - error TS2552: Cannot find name 'request'. Did you mean 'Request'?

884       'database': request.database || '',
                      ~~~~~~~

  node_modules/typescript/lib/lib.dom.d.ts:12776:13
    12776 declare var Request: {
                      ~~~~~~~
    'Request' is declared here.


Found 8 errors.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/firestore@3.5.0 compile: `tsc -p .`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/firestore@3.5.0 compile script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-02-07T12_21_45_326Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! @google-cloud/firestore@3.5.0 prepare: `npm run compile`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the @google-cloud/firestore@3.5.0 prepare script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/kbuilder/.npm/_logs/2020-02-07T12_21_45_380Z-debug.log
npm WARN npm npm does not support Node.js v12.15.0
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm Supported releases of Node.js are the latest release of 6, 8, 9, 10, 11.
npm WARN npm You can find the latest version at https://nodejs.org/

> @google-cloud/firestore@3.5.0 fix /tmpfs/src/git/autosynth/working_repo
> gts fix

installing semver@^5.5.0
installing chalk@^2.4.1
installing minimist@^1.2.0
installing uglify-js@^3.3.25
installing espree@^3.5.4
installing escodegen@^1.9.1
installing estraverse@^4.2.0
synthtool > Wrote metadata to synth.metadata.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2020
@alexander-fenster alexander-fenster changed the title [CHANGE ME] Re-generated to pick up changes in the API or client library generator. fix: pass x-goog-request-params header for streaming calls Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #920 into master will decrease coverage by 0.02%.
The diff coverage is 83.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
- Coverage    96.6%   96.58%   -0.03%     
==========================================
  Files          25       25              
  Lines       15566    15638      +72     
  Branches     1158     1164       +6     
==========================================
+ Hits        15038    15104      +66     
- Misses        519      525       +6     
  Partials        9        9
Impacted Files Coverage Δ
dev/src/v1/firestore_admin_client.ts 89.94% <75.3%> (-0.03%) ⬇️
dev/src/v1beta1/firestore_client.ts 93.22% <93.75%> (-0.01%) ⬇️
dev/src/v1/firestore_client.ts 93.54% <93.75%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 864d77b...7e36422. Read the comment docs.

@alexander-fenster alexander-fenster merged commit cfbe19e into master Feb 7, 2020
@alexander-fenster alexander-fenster deleted the autosynth branch February 7, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-fenster alexander-fenster alexander-fenster approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoshi-automation @alexander-fenster @googlebot