deps: update TypeScript #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
schmidt-sebastian
assigned schmidt-sebastian and JustinBeckwith and unassigned schmidt-sebastian
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 97.45% 97.45%
=======================================
Files 25 25
Lines 15896 15896
Branches 1193 1193
=======================================
Hits 15491 15491
Misses 402 402
Partials 3 3 Continue to review full report at Codecov.
|
JustinBeckwith
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
I'd recommend using a ~ here, since we haven't been bit by patch releases yet :) Overall we were waiting for Angular to start supporting 3.7, which I think has happened. This should be fine. @bcoe as FYI.
|
@schmidt-sebastian whoops, we should have probably added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JustinBeckwith Since we use our own manually generated types, does the reason for not updating all of GCloud to a newer TypeScript version apply to us?