fix: support Query.stream() as first client operation #971
Conversation
This fixes a regression introduced in 3.7
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 97.55% 97.45% -0.11%
==========================================
Files 25 25
Lines 15983 15978 -5
Branches 1283 1208 -75
==========================================
- Hits 15593 15572 -21
- Misses 387 403 +16
Partials 3 3
Continue to review full report at Codecov.
|
| @@ -1277,7 +1280,8 @@ describe('limitToLast() interface', () => { | |||
|
|
|||
| it('requires at least one ordering constraints', () => { | |||
| const query = firestore.collection('collectionId'); | |||
| expect(() => query.limitToLast(1).get()).to.throw( | |||
| const result = query.limitToLast(1).get(); | |||
| return expect(result).to.eventually.be.rejectedWith( | |||
There was a problem hiding this comment.
All the refactor in the original PR was meant to ensure that this is thrown as an exception, rather than as a rejected Promise, but it is probably not worth breaking the client for.
dev/src/reference.ts
Outdated
| @@ -1989,11 +1986,11 @@ export class Query<T = DocumentData> { | |||
| /** | |||
| * Internal streaming method that accepts the request proto. | |||
There was a problem hiding this comment.
The comment is now outdated.
| ); | ||
| this.firestore | ||
| .initializeIfNeeded(tag) | ||
| .then(async () => { |
There was a problem hiding this comment.
async is not needed, there is no await inside.
There was a problem hiding this comment.
I added a comment. async makes sure that any exception from this.toProto is converted into a rejected Promise.
This fixes a regression introduced in 3.7
Fixes #969