Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky contention test #979

Merged
merged 1 commit into from
Mar 22, 2020
Merged

Conversation

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #979 into master will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
- Coverage   97.55%   97.45%   -0.11%     
==========================================
  Files          25       25              
  Lines       15978    15978              
  Branches     1284     1208      -76     
==========================================
- Hits        15588    15572      -16     
- Misses        387      403      +16     
  Partials        3        3              
Impacted Files Coverage Δ
dev/src/order.ts 98.09% <0.00%> (-1.15%) ⬇️
dev/src/pool.ts 97.75% <0.00%> (-0.90%) ⬇️
dev/src/transaction.ts 96.47% <0.00%> (-0.51%) ⬇️
dev/src/watch.ts 98.77% <0.00%> (-0.37%) ⬇️
dev/src/serializer.ts 98.77% <0.00%> (-0.25%) ⬇️
dev/src/validate.ts 98.05% <0.00%> (-0.25%) ⬇️
dev/src/reference.ts 99.80% <0.00%> (-0.08%) ⬇️
dev/src/index.ts 98.62% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad64951...35b7033. Read the comment docs.

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit f294998 into master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mocha Tests: retries transactions that fail with contention failed
3 participants