Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support array of references for IN queries #993

Merged
merged 4 commits into from
Mar 31, 2020
Merged

fix: support array of references for IN queries #993

merged 4 commits into from
Mar 31, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This ports the validation from Web.

Fixes #990

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 31, 2020
@schmidt-sebastian
Copy link
Contributor Author

@thebrianchen We may need to port this to Java too.

@codecov
Copy link

codecov bot commented Mar 31, 2020 •
edited
Loading

Codecov Report

Merging #993 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #993      +/-   ##
==========================================
- Coverage   97.57%   97.46%   -0.12%     
==========================================
  Files          25       25              
  Lines       15986    16002      +16     
  Branches     1285     1216      -69     
==========================================
- Hits        15599    15596       -3     
- Misses        384      403      +19     
  Partials        3        3
Impacted Files Coverage Δ
dev/src/reference.ts 99.8% <100%> (-0.08%) ⬇️
dev/src/order.ts 98.09% <0%> (-1.15%) ⬇️
dev/src/pool.ts 97.75% <0%> (-0.9%) ⬇️
dev/src/transaction.ts 96.47% <0%> (-0.51%) ⬇️
dev/src/watch.ts 98.77% <0%> (-0.37%) ⬇️
dev/src/document.ts 98.65% <0%> (-0.29%) ⬇️
dev/src/serializer.ts 98.77% <0%> (-0.25%) ⬇️
dev/src/validate.ts 98.05% <0%> (-0.25%) ⬇️
dev/src/index.ts 98.62% <0%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f1c1aa...044e761. Read the comment docs.

thebrianchen
thebrianchen reviewed Mar 31, 2020
View reviewed changes
dev/system-test/firestore.ts Outdated
@@ -1184,6 +1193,15 @@ describe('Query class', () => {
expectDocs(res, {zip: 98101}, {zip: 98103});
});

it('supports "in" with document ID array', async () => {
setLogFunction(console.log);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hanging log function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

thebrianchen
thebrianchen approved these changes Mar 31, 2020
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for fixing!

@schmidt-sebastian schmidt-sebastian merged commit a6d8fe0 into master Mar 31, 2020
@thebrianchen thebrianchen mentioned this pull request May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebrianchen thebrianchen thebrianchen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
3 participants
@schmidt-sebastian @thebrianchen @googlebot