Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated code generation reverts some of migration #63

Open
bcoe opened this issue Mar 30, 2021 · 0 comments
Open

Automated code generation reverts some of migration #63

bcoe opened this issue Mar 30, 2021 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@bcoe
Copy link
Contributor

bcoe commented Mar 30, 2021

@sofisl @billyjacobson the following PR shows that our automated code generation reverts a couple of the changes made to move us away from using the master branch name.

The GitHub action should be easy to fix, we can just update the templates to use the $default-branch variable, and it should work across the board.

Perhaps we could introduce similar functionality to our templates, and do the same thing?
@bcoe bcoe added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Mar 30, 2021
@sofisl sofisl added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Mar 30, 2021
@SurferJeffAtGoogle SurferJeffAtGoogle added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 28, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Dec 25, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bcoe @SurferJeffAtGoogle @yoshi-automation @sofisl