Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use defaultCallback in LoggingCommon class #672

Merged
merged 4 commits into from
Mar 9, 2022
Merged

fix: Use defaultCallback in LoggingCommon class #672

merged 4 commits into from
Mar 9, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Mar 9, 2022

Error handling with a default global callback has an issue - winston library always uses default callback, so LoggingCommon need to override it.

Fixes #<627> 馃

@losalex losalex self-assigned this Mar 9, 2022
@losalex losalex requested review from a team as code owners March 9, 2022 01:48
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/nodejs-logging-winston API. labels Mar 9, 2022
@losalex losalex merged commit 4bc7baa into main Mar 9, 2022
@losalex losalex deleted the losalex/fix-627-correction branch March 9, 2022 16:45
@release-please release-please bot mentioned this pull request Mar 9, 2022
Merged
@losalex losalex added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbrown arbrown arbrown approved these changes

Assignees

@losalex losalex

Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. priority: p2 Moderately-important priority. Fix may not be included in next release. size: xs Pull request size is extra small. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@losalex @arbrown