Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch instrumentation code to return version stored in NODEJS_WINSTON_DEFAULT_LIBRARY_VERSION #764

Merged
merged 5 commits into from
Nov 7, 2022

Conversation

losalex
Copy link
Contributor

@losalex losalex commented Nov 4, 2022

Fixes #759 🦕

@losalex losalex requested review from a team as code owners November 4, 2022 23:25
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 4, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging-winston API. label Nov 4, 2022
@losalex losalex added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 7, 2022
@losalex losalex merged commit 3e23e5a into main Nov 7, 2022
@losalex losalex deleted the losalex/fix-switch-annotations branch November 7, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/nodejs-logging-winston API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants