Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

typo on line 48 #136

Closed
ihsansengun opened this issue Apr 29, 2021 · 3 comments · Fixed by #155
Closed

typo on line 48 #136

ihsansengun opened this issue Apr 29, 2021 · 3 comments · Fixed by #155
Assignees
@telpirion
Labels
api: mediatranslation Issues related to the googleapis/nodejs-media-translation API. needs more info This issue needs more information from the customer to proceed. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ihsansengun
Copy link

nodejs-media-translation/samples/quickstart.js

Line 48 in cfaeb1c

targetLanguageCode: targetLanguage,

@product-auto-label product-auto-label bot added the api: mediatranslation Issues related to the googleapis/nodejs-media-translation API. label Apr 29, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 30, 2021
@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. needs more info This issue needs more information from the customer to proceed. labels May 4, 2021
@bcoe
Copy link
Contributor

bcoe commented May 4, 2021

@ihsansengun the typo isn't jumping out at me, what's wrong with this code?

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label May 5, 2021
@ihsansengun
Copy link
Author

In the comment, there is a little misspelling. // targetLangauge, which isn't a big concern, but it can be confusing when you first time uncomment it and assign a value (BCP-47)

@telpirion telpirion self-assigned this Jun 21, 2021
@munkhuushmgl
Copy link

munkhuushmgl commented Jun 21, 2021 •
edited
Loading

I do not understand what you are suggesting to change.
Could you share code snippet for this [demonstration purpose]?

@ihsansengun

@telpirion telpirion mentioned this issue Jun 21, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@telpirion telpirion

Labels
api: mediatranslation Issues related to the googleapis/nodejs-media-translation API. needs more info This issue needs more information from the customer to proceed. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples: another typo in comments googleapis/nodejs-media-translation
5 participants
@bcoe @telpirion @ihsansengun @yoshi-automation @munkhuushmgl