Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix: do not modify options object, use defaultScopes #497

Merged
merged 2 commits into from
Nov 7, 2020

Conversation

alexander-fenster
Copy link
Contributor

Regenerated the library using
gapic-generator-typescript
v1.2.1.

@alexander-fenster alexander-fenster requested a review from a team as a code owner November 6, 2020 22:28
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 6, 2020
@product-auto-label product-auto-label bot added the api: monitoring Issues related to the googleapis/nodejs-monitoring API. label Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #497 (976e414) into master (69f9bcf) will decrease coverage by 0.02%.
The diff coverage is 97.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   98.57%   98.55%   -0.03%     
==========================================
  Files          10       10              
  Lines       16132    16292     +160     
  Branches      371      353      -18     
==========================================
+ Hits        15902    16056     +154     
- Misses        224      230       +6     
  Partials        6        6              
Impacted Files Coverage Δ
src/v3/alert_policy_service_client.ts 98.66% <96.47%> (-0.04%) ⬇️
src/v3/group_service_client.ts 98.62% <97.36%> (-0.03%) ⬇️
src/v3/uptime_check_service_client.ts 98.59% <97.36%> (-0.03%) ⬇️
src/v3/notification_channel_service_client.ts 98.72% <97.76%> (-0.02%) ⬇️
src/v3/service_monitoring_service_client.ts 98.67% <97.76%> (-0.02%) ⬇️
src/v3/metric_service_client.ts 98.76% <97.97%> (-0.03%) ⬇️
src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69f9bcf...976e414. Read the comment docs.

@bcoe bcoe added the automerge Merge the pull request once unit tests and other checks pass. label Nov 6, 2020
@alexander-fenster alexander-fenster merged commit 447cfce into master Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: monitoring Issues related to the googleapis/nodejs-monitoring API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants