This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: update alert policies one at a time because (concurrent updates are not supported) #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport concurrent updates to alert policies
product-auto-label
bot
added
the
api: monitoring
google-cla
bot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #507 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 10 10
Lines 16338 16338
Branches 353 359 +6
=======================================
Hits 16096 16096
Misses 236 236
Partials 6 6 Continue to review full report at Codecov.
|
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
@syedashrafulla it looks like there are a couple linting issues to address, I kicked off the integration tests so you can see if things are working. |
|
@bcoe apologies about that, lint should now be cleaned. |
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
|
I think all that's missing is now a review, but let me know if I should run a test. |
bcoe
changed the title
bcoe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
bcoe
approved these changes
Dec 22, 2020
|
@syedashrafulla thank you for the contribution. |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 7, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.5](https://www.github.com/googleapis/nodejs-monitoring/compare/v2.1.4...v2.1.5) (2021-01-07) ### Bug Fixes * update alert policies one at a time because (concurrent updates are not supported) ([#507](https://www.github.com/googleapis/nodejs-monitoring/issues/507)) ([2bf75a2](https://www.github.com/googleapis/nodejs-monitoring/commit/2bf75a2294f82d3b75e0ee3d44c91b0b8e5ec358)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #506 🦕