Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stops working when project is using opentelemetry-js 0.18+ packages #1233

Closed
weyert opened this issue Mar 17, 2021 · 2 comments · Fixed by #1234
Closed

Stops working when project is using opentelemetry-js 0.18+ packages #1233

weyert opened this issue Mar 17, 2021 · 2 comments · Fixed by #1234
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@weyert
Copy link
Contributor

weyert commented Mar 17, 2021

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

  1. Is this a client library issue or a product issue?
    Yes, this is a client library issue

  2. Did someone already solve this?
    There renovatebot made a PR to solve this problem

  3. Do you have a support contract?
    No

Environment details

  • OS: macOS 11.2.3
  • Node.js version: 14.16.0
  • npm version: 6.x
  • @google-cloud/pubsub version: 2.10.0

Steps to reproduce

  1. Create new directory
  2. npm init -y
  3. Install the dependencies npm install @google-cloud/pubsub @opentelemetry/core @opentelemetry/api
  4. npm ls @opentelemetry/tracing
  5. Notice that the installed version is 0.12 instead of the 0.18 version meets the Opentelemetry 1.0.0 tracing spec

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Mar 17, 2021
@weyert weyert mentioned this issue Mar 17, 2021
Merged
4 tasks
@weyert weyert changed the title Upgrade opentelemetry packages to 0.18+ Stops working when project is using opentelemetry-js 0.18+ packages Mar 18, 2021
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Mar 19, 2021
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Mar 22, 2021
@feywind
Copy link
Collaborator

feywind commented Mar 22, 2021

Oops, I didn't do the label triage. I'm going to consider it a bug since this has been broken for a while, and there is a fix in progress.

@weyert weyert mentioned this issue Apr 1, 2021
Closed
@weyert
Copy link
Contributor Author

weyert commented Apr 1, 2021

@feywind Can you please review the PR? All tests are passing 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added support for Opentelemetry 0.18
3 participants
@weyert @yoshi-automation @feywind