fix: handle receipt modAck and lease extensions with exactly-once delivery correctly #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…delivery if the receipt modAck fails
…y-once delivery enabled
product-auto-label
bot
added
size: l
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
acocuzzo
approved these changes
Apr 13, 2023
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| message.modAckWithResponse(deadline).catch(() => { | ||
| // In the case of a permanent failure (temporary failures are retried), | ||
| // we need to stop trying to lease-manage the message. | ||
| this.remove(message); |
There was a problem hiding this comment.
We should be setting the response for the eventual ack as failed as well. This way, when the client acks the message, we do not have to issue a server call. If the modack fails with a permanent error, ack will also fail with a permanent error.
There was a problem hiding this comment.
@maheshgattani Can you check the change I just made to validate that it meets the requirements? The ack/modAck/nack methods will only throw a failure if the error is permanent, so I think this covers it.
feywind
added
the
do not merge
feywind
added
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
maheshgattani
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes in this one:
I also discovered that we were missing a bunch of unit tests around this stuff, so I added some more.
Fixes #1697