Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible race condition between Topic.flush and OrderedQueue.publish #1746

Closed
feywind opened this issue Jun 8, 2023 · 0 comments · Fixed by #1747
Closed

Possible race condition between Topic.flush and OrderedQueue.publish #1746

feywind opened this issue Jun 8, 2023 · 0 comments · Fixed by #1747
Assignees
@feywind
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@feywind
Copy link
Collaborator

feywind commented Jun 8, 2023

It's theoretically possible that calling topic.flush() would pull a reference to an ordered queue that would emit 'drain' (and thus be deleted) after the topic.flush() starts. This could result in calling queue.publish() and a reference error.
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 8, 2023
@feywind feywind self-assigned this Jun 8, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jun 8, 2023
@feywind feywind mentioned this issue Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't crash if an already-drained/removed queue gets flushed again feywind/nodejs-pubsub
1 participant
@feywind